Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to GraphQL Playground latest. #1855

Merged
merged 2 commits into from
Oct 26, 2018

Conversation

abernix
Copy link
Member

@abernix abernix commented Oct 24, 2018

In addition to updating the @apollographql/graphql-playground-html fork,
which is necessary to avoid bundling graphql-config which had been
problematic in serverless environments, this updates the version number
which is served from the CDN.

I've just published @apollographql/graphql-playground-html@1.6.4.

Closes: #1746
Ref: apollographql/graphql-playground#2
Ref: apollographql/graphql-playground#1

Thanks for @javlund for kicking off some of this work!

In addition to updating the `@apollographql/graphql-playground-html` fork,
which is necessary to avoid bundling `graphql-config` which had been
problematic in serverless environments, this updates the version number
which is served from the CDN.

I've just published `@apollographql/graphql-playground-html@1.6.4`.

Ref: #1746
Ref: apollographql/graphql-playground#2
Ref: apollographql/graphql-playground#1

Thanks for @javlund for kicking off some of this work!
@javlund
Copy link

javlund commented Oct 24, 2018

@abernix Happy to help! :)

@abernix abernix changed the title Update to GraphQL Playground 1.7.8. Update to GraphQL Playground latest. Oct 25, 2018
@abernix
Copy link
Member Author

abernix commented Oct 25, 2018

It's worth pointing out some subtle nuances in versioning between the various GraphQL Playground integrations (e.g. Electron, React, HTML) that might be interpreted incorrectly here. From best I can tell, this PR updates GraphQL Playground to the latest possible version for the needs of Apollo Server so I've updated the title of this PR accordingly. Here's a quick look at the graphql-playground repo's various versions:

$ ls -1 packages/*/package.json | xargs -tL1 jq .version
jq .version packages/graphql-playground-electron/package.json
"1.8.0"
jq .version packages/graphql-playground-html/package.json
"1.6.4"
jq .version packages/graphql-playground-middleware-express/package.json
"1.7.6"
jq .version packages/graphql-playground-middleware-hapi/package.json
"1.7.5"
jq .version packages/graphql-playground-middleware-koa/package.json
"1.6.6"
jq .version packages/graphql-playground-middleware-lambda/package.json
"1.7.6"
jq .version packages/graphql-playground-react/package.json
"1.7.8"

As noted above, we're using a fork of graphql-playground-html which removes the graphql-config dependency, but -html loads its assets from the graphql-playground-react version on jsDelivr's CDN, as seen in this code.

So the relevant versions from above are:

graphql-playground-html: 1.6.4

I published this as @apollographql/graphql-playground-html@1.6.4 yesterday.

graphql-playground-react: 1.7.8

This is the latest version, and this is loaded from the CDN based on the version we pass in from Apollo Server. This PR correctly changes that graphql-playground-react reference to 1.7.8:

const playgroundVersion = '1.7.8';

graphql-playground-electron: 1.8.0

This isn't actually relevant to Apollo Server at all, but I'm pointing it out because it's what their repository lists as the "latest" version on their releases page and it's worth demonstrating why the apparent version discrepancy exists, primarily for the sake of prosperity and the next person who updates this:

It's actually the version of `graphql-playground-react` which is getting
served by `graphql-playground-html`.
@abernix abernix force-pushed the abernix/update-graphql-playground-1.7.8 branch from 6b84bcf to 9130b8c Compare October 25, 2018 10:14
@abernix abernix merged commit c229b93 into master Oct 26, 2018
@abernix abernix deleted the abernix/update-graphql-playground-1.7.8 branch October 26, 2018 17:06
@abernix
Copy link
Member Author

abernix commented Oct 26, 2018

This should be released as 2.2.0-alpha.1! 🎉

@edarblanco
Copy link

My apologies in advance my native language is not english, I would like to know if it is possible or not to use offline playground, I did what I described here Apollo Offline and even then I do not get results, my apollo-server version is 2.3.1 and it was said that it would be for version 2.2 if I have skipped something, please light me, thank you

@abernix abernix removed this from the Release 2.x milestone Jun 28, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQL Playground settings do not get set
3 participants